Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base.html, create blocks for template abstraction #45

Closed
wants to merge 1 commit into from

Conversation

dgmouris
Copy link
Contributor

@dgmouris dgmouris commented Oct 4, 2019

Issue: #36

I've added quite a few blocks, but I can change this if need be I just thought some of these would be handy in the future:)

@ethanchewy
Copy link
Owner

Overall, good job!

I'm going to leave this open for the meantime while I rethink about what features I want to add onto PythonBuddy and how to format the templating.

For example, I think for the base file, we should include any of the code content blocks because for future pages like when a user logs in, views their previous submissions, they won't need the code block.

@ethanchewy ethanchewy closed this Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants