Skip to content

Commit

Permalink
Fix drawer stylings (Shopify#3248)
Browse files Browse the repository at this point in the history
* Update 1 translation file (Shopify#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Pull update from release branch and update version number and release notes (Shopify#3229)

* Fix translation path (Shopify#3198)

* Change product variant swatches' border color (Shopify#3204)

* change color reference

* remove character

* increase to meet contrast ratio of 3

* Update swatch setting info text (Shopify#3205)

* Update info text

* remove duplication

* add space

* clean up language and association

* add to second place

* Update 9 translation files

* Update 4 translation files

* Update 6 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (Shopify#3203)

* Change the message when removing only one item from the QOL

* Update 20 translation files

* Update 6 translation files

* Update 4 translation files

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* update version number and release notes

---------

Co-authored-by: melissaperreault <[email protected]>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Eugene Kasimov <[email protected]>

* Update 1 translation file (Shopify#3232)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Fix cart drawer header background and cart note summary spacing

* more cart drawer touch ups

* remove some of the unwanted changes

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: melissaperreault <[email protected]>
Co-authored-by: Eugene Kasimov <[email protected]>
  • Loading branch information
4 people authored and ethanclevenger91 committed Feb 27, 2024
1 parent e3a250d commit f5059a7
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
13 changes: 7 additions & 6 deletions assets/component-cart-drawer.css
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ cart-drawer:not(.is-empty) .cart-drawer__collection {
}

.drawer__close svg {
height: 2.4rem;
width: 2.4rem;
height: 2rem;
width: 2rem;
}

.drawer__contents {
Expand Down Expand Up @@ -132,7 +132,7 @@ cart-drawer-items.is-empty + .drawer__footer {
display: flex;
position: relative;
line-height: 1;
padding: 1.5rem 0;
padding: 1.5rem 2.8rem 1.5rem 0;
}

.drawer__footer > details + .cart-drawer__footer {
Expand Down Expand Up @@ -185,6 +185,7 @@ cart-drawer {
position: sticky;
top: 0;
z-index: 2;
background-color: rgb(var(--color-background));
}

cart-drawer-items {
Expand All @@ -205,7 +206,7 @@ cart-drawer-items {
.cart-drawer .cart-item {
display: grid;
grid-template: repeat(2, auto) / repeat(4, 1fr);
gap: 1.5rem;
gap: 1rem;
margin-bottom: 0;
}

Expand Down Expand Up @@ -255,7 +256,7 @@ cart-drawer-items {
}

.cart-drawer .cart-items td {
padding-top: 2rem;
padding-top: 1.7rem;
}

.cart-drawer .cart-item > td + td {
Expand Down Expand Up @@ -312,7 +313,7 @@ cart-drawer-items {
}

.cart-drawer .tax-note {
margin: 1.2rem 0 1rem auto;
margin: 1.2rem 0 2rem auto;
text-align: left;
}

Expand Down
10 changes: 5 additions & 5 deletions release-notes.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Dawn 12.0.0 introduces additional customization options by adding color scheme pickers to new areas, and new ways to visually display product filters. It also introduces some performance improvements related to image loading.
Dawn 12.0.0 introduces additional customization options by adding color scheme pickers to new areas, and new ways to visually display product filters. It also introduces some performance improvements related to image loading.

### Added
- Important: If you use a gradient as a main background, the look of your cart drawer and product modal (quick add) will be affected.
- Important: If you use a gradient as a main background, the look of your cart drawer and product modal (quick add) will be affected.
- You can now select a color scheme for the Image with text section, Collection template (Product grid section), Product information section, Cart drawer, and Cart page.

### Changed
Expand All @@ -15,9 +15,9 @@ Dawn 12.0.0 introduces additional customization options by adding color scheme p
- We fixed an issue with the “compare at” price to ensure more predictable behavior.
- We’ve improved the experience of adding items to cart on slower connections.
- We fixed a styling issue affecting collections in empty cart drawers.
- We fixed an issue in the Slideshow section where the next slide flashes before coming into view.
- We’ve improved various visual elements on the Quick order list including font consistency, alignment, and spacing.
- We fixed an issue in the Slideshow section where the next slide flashes before coming into view.
- We’ve improved various visual elements on the Quick order list including font consistency, alignment, and spacing.
- We fixed an issue affecting Quick order list on iOS, removing the need to double tap the info icon to open it.

### Removed
- Removed image tag attribute that indicated which images to load first. We will now allow the platform to determine this, which will improve performance.
- Removed image tag attribute that indicated which images to load first. We will now allow the platform to determine this, which will improve performance.

0 comments on commit f5059a7

Please sign in to comment.