Skip to content
This repository has been archived by the owner on Apr 11, 2021. It is now read-only.

Fix three terribly named variables #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

karlfloersch
Copy link
Contributor

@karlfloersch karlfloersch commented Feb 2, 2021

There were a few terribly named variables that have been left around.

Just updating these names for a little added sanity -- there's a bunch more refactoring needed but this at least goes in the right direction towards a sane batch submitter.

@karlfloersch
Copy link
Contributor Author

karlfloersch commented Feb 2, 2021

Update: Ugh. I'm a little unhappy about the fact that we have two types: Batch and SequenceTransactionBatch. Maybe these names require a bit more thought. At least we should absolutely change startsAtBatch which is just an utterly terrible name.

I'm down for either name for appendSequencerBatchParams or SequencerTransactionBatch. Let me know which y'all prefer and we can pick the relevant commit.

@tynes
Copy link
Collaborator

tynes commented Feb 13, 2021

I like SequencerTransactionBatch more

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants