This repository has been archived by the owner on Apr 11, 2021. It is now read-only.
Unit Add to Variables #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: MS after POLL_INTERVAL Added: S after MAX_SUBMISSION_TIME Added: S after RESUBMISSION_TIMEOUT
|
The integration tests will fail until there is a corresponding change to the config here: https://github.com/ethereum-optimism/optimism-integration/blob/07039ba799707c36cde95e21795fcf2feff16f09/docker-compose.env.yml#L58 |
Created a pull request on that repository: ethereum-optimism/optimism-integration#94 Do these need unit variables as well?
|
walkingbackward
changed the title
|
@tynes how do you think we should proceed here? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: MS after POLL_INTERVAL
Added: S after MAX_SUBMISSION_TIME
Added: S after RESUBMISSION_TIMEOUT
Not sure if I am replacing patch 1 pull request correctly; could not figure know how to edit my patch 1 pull request.
REF: #50