chore: Add inputs to kurtosis-op workflow to override op-geth and op-node images [OPTION 1] #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjakubnanista
changed the title
emhane
requested changes
Jan 21, 2025
| cl_type: $KURTOSIS_CL_TYPE | ||
| cl_image: $KURTOSIS_CL_IMAGE | ||
| - el_type: op-reth | ||
| el_image: "ghcr.io/paradigmxyz/op-reth:kurtosis-ci" |
There was a problem hiding this comment.
Suggested change
| el_image: "ghcr.io/paradigmxyz/op-reth:kurtosis-ci" | |
| el_image: "ghcr.io/ethereum-optimsim/op-reth:kurtosis-ci" |
no? this should be able to run op-reth image built from branch specified in workflow dispatch
There was a problem hiding this comment.
Yessss. I added the two dependencies as submodules to avoid having to fiddle with github permissions. When you dispatch and leave the two parameters to their defaults (HEAD), it will use the submodules as they are. If you add a git revision (commit hash or branch should work), it will checkout that version of the submodule.
janjakubnanista
force-pushed
the
jan/workflow
branch
2 times, most recently
from
b54ccfc to
6e8e17f
Compare
janjakubnanista
force-pushed
the
jan/workflow
branch
from
6e8e17f to
722e06a
Compare
janjakubnanista
changed the title
emhane
reviewed
Jan 22, 2025
| cl_type: op-node | ||
| cl_image: "ghcr.io/ethereum-optimism/op-node:kurtosis-ci" | ||
| - el_type: op-reth | ||
| el_image: "ghcr.io/paradigmxyz/op-reth:kurtosis-ci" |
There was a problem hiding this comment.
Suggested change
| el_image: "ghcr.io/paradigmxyz/op-reth:kurtosis-ci" | |
| el_image: "ghcr.io/ethereum-optimism/op-reth:kurtosis-ci" |
|
Closing in favor of #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
op-nodeandop-gethimage building to thekurtosis-opworkflowop-node-reforop-geth-refare set in the workflow parameters, these will be checked out and builtFixes #14