fix(optimism): Node Tests #47
Conversation
| use reth_primitives::TransactionSigned; | ||
| let provider = MockEthProvider::<TransactionSigned>::default(); |
There was a problem hiding this comment.
These changes stink but i think it's unavoidable, even though i hid the op impls behind the optimism feature flag
There was a problem hiding this comment.
eventually we want to remove those op feature flags anyway, I don't think it stinks so bad :)
| use reth_primitives::TransactionSigned; | ||
| let provider = MockEthProvider::<TransactionSigned>::default(); |
There was a problem hiding this comment.
eventually we want to remove those op feature flags anyway, I don't think it stinks so bad :)
emhane
added
upstream
| @@ -164,6 +164,26 @@ impl StateCommitmentProvider for MockEthProvider { | |||
| type StateCommitment = <MockNode as NodeTypes>::StateCommitment; | |||
There was a problem hiding this comment.
| type StateCommitment = <MockNode as NodeTypes>::StateCommitment; | |
| impl<T> StateCommitmentProvider for MockEthProvider<T> { | |
| type StateCommitment = <MockNode as NodeTypes>::StateCommitment; |
this is instead fixed by generalising the impls. in some cases you may need trait bound T: reth_primitive_traits::SignedTransaction
There was a problem hiding this comment.
this change is what we want to upstream, but I'm merging this pr into the base branch anyway to unblock
There was a problem hiding this comment.
opened an issue paradigmxyz#14038
Description
Fixes node tests in the transaction pool using the updated
OpTransactionSigned. This requires implementing traits on theMockEthProviderwith the concrete generic instead of the defaultT = TransactionSignedgeneric.Closes #45