Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set withdrawals root in genesis header #48

Merged
merged 12 commits into from
Jan 28, 2025
Merged

Set withdrawals root in genesis header #48

merged 12 commits into from
Jan 28, 2025

Conversation

emhane
Copy link
Member

@emhane emhane commented Jan 28, 2025 •
edited
Loading

  • Sets withdrawals root in genesis header upon construction of OpChainSpec
  • Restricts visibility of inner ChainSpec type to private, to ensure safe construction of OpChainSpec always updates the header and genesis header hash

@emhane emhane added the D-isthmus-devnet-0 Devnet: l2 withdrawals root devnet label Jan 28, 2025
@emhane emhane merged commit 90178df into isthmus-devnet-0 Jan 28, 2025
20 of 27 checks passed
@emhane emhane deleted the emhane/genesis-header branch January 28, 2025 21:01
This was referenced Jan 29, 2025
Closed
Open
@emhane emhane added the upstream A pr solving this issue has been opened in upstream label Jan 29, 2025
@emhane emhane restored the emhane/genesis-header branch January 29, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
D-isthmus-devnet-0 Devnet: l2 withdrawals root devnet upstream A pr solving this issue has been opened in upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emhane