Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add game type event #14196

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

feat: add game type event #14196

wants to merge 23 commits into from
+172 −18

Conversation

maurelian
Copy link
Contributor

Fixes #14140

@maurelian maurelian requested a review from a team as a code owner February 5, 2025 22:05
@mslipper mslipper force-pushed the opcm/addGameType-event branch from 2468391 to 1e2d3b5 Compare February 5, 2025 22:08
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.57%. Comparing base (af89e49) to head (d9e61c0).

❗ There is a different number of reports uploaded between BASE (af89e49) and HEAD (d9e61c0). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (af89e49) HEAD (d9e61c0)
cannon-go-tests-32 1 0
cannon-go-tests-64 1 0
contracts-bedrock-tests 2 1
Additional details and impacted files 
@@                Coverage Diff                 @@
##           oppu/comments   #14196       +/-   ##
==================================================
- Coverage          80.69%   44.57%   -36.12%     
==================================================
  Files                166      951      +785     
  Lines               9350    81751    +72401     
==================================================
+ Hits                7545    36444    +28899     
- Misses              1636    42487    +40851     
- Partials             169     2820     +2651
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 94.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/contracts-bedrock/src/L1/OPContractsManager.sol 99.17% <100.00%> (+0.01%) ⬆️
...racts-bedrock/src/L1/OPContractsManagerInterop.sol 100.00% <100.00%> (ø)

... and 899 files with indirect coverage changes

mds1
mds1 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outstanding comments are non-blockers, feel free to resolve at your discretion

@maurelian maurelian changed the base branch from develop to graphite-base/14196 February 11, 2025 14:44
@maurelian maurelian force-pushed the opcm/addGameType-event branch from 29bf6c9 to 5797bad Compare February 11, 2025 14:44
@maurelian maurelian changed the base branch from graphite-base/14196 to exempt-frozen-files February 11, 2025 14:45
@maurelian Graphite App
Copy link
Contributor Author

maurelian commented Feb 11, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maurelian maurelian mentioned this pull request Feb 11, 2025
Merged
@maurelian maurelian force-pushed the opcm/addGameType-event branch from 5797bad to 3c04934 Compare February 11, 2025 14:54
@maurelian maurelian changed the base branch from exempt-frozen-files to freeze-exceptions February 11, 2025 21:10
@maurelian maurelian force-pushed the opcm/addGameType-event branch from 3c04934 to ca80501 Compare February 11, 2025 21:15
@maurelian maurelian requested review from a team as code owners February 11, 2025 21:15
@maurelian maurelian requested review from ControlCplusControlV, zhwrd, axelKingsley and protolambda and removed request for a team February 11, 2025 21:15
@maurelian maurelian added the S-exempt-frozen-files Status: Exempt from frozen code label Feb 12, 2025
@maurelian maurelian changed the base branch from develop to graphite-base/14196 February 12, 2025 17:16
@maurelian maurelian force-pushed the opcm/addGameType-event branch from 55381b3 to 7594c00 Compare February 12, 2025 17:16
@maurelian maurelian changed the base branch from graphite-base/14196 to oppu/comments February 12, 2025 17:17
@maurelian maurelian mentioned this pull request Feb 12, 2025
Merged
Base automatically changed from oppu/comments to develop February 12, 2025 19:31
alcueca and others added 23 commits February 12, 2025 14:34
@maurelian
feat: Ignore frozen files check by using a PR label
93728f2
@maurelian
fix: following https://github.com/orgs/community/discussions/26712
0babff2
@maurelian
fix: maybe
4d7ace6
@maurelian
fix: follow existing pattern
c0ddd48
@maurelian
fix: temporarily remove the contracts changed check to make it run
26b5906
@maurelian
spike: Using jq instead of grep
433df9a
@maurelian
fix: don't extract labels twice
ae49708
@maurelian
fix: a bit cleaner output
2296aee
@maurelian
fix: minor change to trigger CI again
39deb8b
@maurelian
fix: Bring back the change check
17d66eb
@maurelian
ci: use circleci-agent step halt to end job
bd7d438
@maurelian
fix: temporarily remove the contracts changed check to make it run
cc3b6a4
@maurelian
fix: Bring back the change check
8dde752
@maurelian
fix: temporarily remove the contracts changed check to make it run
613d542
@maurelian
fix: Bring back the change check
8e88746
@maurelian
feat: add game type event
64a1ef4
@maurelian
lint and semver-lock
75717c1
@maurelian
snapshtos
88b7c20
@maurelian
feat: add old dispute game address to event
ab37e6f
@maurelian
feat: update semver-lock and oppu interface
15fc23d
@maurelian
feat: bump opcminterop semver too
a0f0d0e
@maurelian
snapshots
ad99fa3
@maurelian
semver
ca61120
@maurelian maurelian force-pushed the opcm/addGameType-event branch from d9e61c0 to ca61120 Compare February 12, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 approved these changes

@smartcontracts smartcontracts Awaiting requested review from smartcontracts smartcontracts is a code owner automatically assigned from ethereum-optimism/contract-reviewers

@ControlCplusControlV ControlCplusControlV Awaiting requested review from ControlCplusControlV ControlCplusControlV was automatically assigned from ethereum-optimism/proofs

@zhwrd zhwrd Awaiting requested review from zhwrd zhwrd was automatically assigned from ethereum-optimism/op-conductor

@axelKingsley axelKingsley Awaiting requested review from axelKingsley axelKingsley was automatically assigned from ethereum-optimism/interop

@protolambda protolambda Awaiting requested review from protolambda protolambda was automatically assigned from ethereum-optimism/consensus

Assignees
No one assigned
Labels
S-exempt-frozen-files Status: Exempt from frozen code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OPCM fix: addGameType does not emit an event (OPCM - Upgrade 13)
2 participants
@maurelian @mds1