Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AnchorStateRegistry: remove blacklist check in getAnchorRoot #14232

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

wildmolasses
Copy link
Collaborator

@wildmolasses wildmolasses commented Feb 6, 2025

Description

Re: incident response improvements audit issue 19: Blacklisted anchorGame in AnchorStateRegistry prevents submitting L2 root claims to L1

"Anchor game gets blacklisted" is an edge case that should never happen given our system assumptions. That said, our implementation accounted for this case by insisting on manual intervention. This broke an L2Beat stage 1 condition. So, we remove the handling of this edge case and the imposition of manual intervention, and rest instead on the assumption aASR-004

@wildmolasses wildmolasses requested a review from a team as a code owner February 6, 2025 18:33
@wildmolasses wildmolasses requested a review from mds1 February 6, 2025 18:33
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.34%. Comparing base (192e511) to head (8e330bd).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14232      +/-   ##
===========================================
- Coverage    45.60%   44.34%   -1.26%     
===========================================
  Files         1006      949      -57     
  Lines        85982    81307    -4675     
===========================================
- Hits         39208    36056    -3152     
+ Misses       43796    42442    -1354     
+ Partials      2978     2809     -169     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 94.39% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tracts-bedrock/src/dispute/AnchorStateRegistry.sol 100.00% <100.00%> (ø)

... and 65 files with indirect coverage changes

@wildmolasses wildmolasses changed the title fix: AnchorStateRegistry: remove blacklist check in getAnchorRoot fix: AnchorStateRegistry: remove blacklist check in getAnchorRoot Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants