Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement EIP-7251 end-to-end test #14253

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

meyer9
Copy link
Contributor

@meyer9 meyer9 commented Feb 7, 2025

Description

Adds a test to deploy withdrawal queue and consolidation queue and sends a valid transaction to each queue to ensure it can be mined post-Isthmus.

Metadata

Blocked by ethereum-optimism/op-geth#498

Fixes #14155

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 41.45%. Comparing base (d44bbea) to head (10bf840).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
op-program/client/l2/engineapi/block_processor.go 0.00% 7 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (d44bbea) and HEAD (10bf840). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (d44bbea) HEAD (10bf840)
contracts-bedrock-tests 2 0
cannon-go-tests-32 2 0
cannon-go-tests-64 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14253       +/-   ##
============================================
- Coverage    81.62%   41.45%   -40.18%     
============================================
  Files          165      842      +677     
  Lines         9313    76837    +67524     
============================================
+ Hits          7602    31853    +24251     
- Misses        1532    42176    +40644     
- Partials       179     2808     +2629     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-program/client/l2/engineapi/block_processor.go 51.63% <0.00%> (ø)

... and 1006 files with indirect coverage changes

@meyer9 meyer9 force-pushed the meyer9/check-eip-7251-7002-processing branch from 76f094d to 10bf840 Compare February 7, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

op-e2e: add e2e test to ensure nothing breaks when EIP-7251, EIP-7002 contract is deployed
1 participant