feat: SuperchainETHWrapper contract
#167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying supersim with
|
| Latest commit: |
12e0c76
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3598cf14.supersim.pages.dev |
| Branch Preview URL: | https://harry-superchain-weth-wrappe.supersim.pages.dev |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @tremarkley and the rest of your teammates on |
tremarkley
force-pushed
the
harry/superchain_weth_wrapper
branch
2 times, most recently
from
cd11ab8
to
2177e9d
Compare
tremarkley
force-pushed
the
09-23-feat_deploy_proxies
branch
from
dfdc930
to
ed60757
Compare
tremarkley
force-pushed
the
harry/superchain_weth_wrapper
branch
from
2177e9d
to
556ab8b
Compare
tremarkley
force-pushed
the
09-23-feat_deploy_proxies
branch
from
ed60757
to
213ffef
Compare
tremarkley
force-pushed
the
harry/superchain_weth_wrapper
branch
from
556ab8b
to
4b1f0e8
Compare
tremarkley
force-pushed
the
09-23-feat_deploy_proxies
branch
from
213ffef
to
0287404
Compare
tremarkley
force-pushed
the
harry/superchain_weth_wrapper
branch
2 times, most recently
from
aed2920
to
b46dabb
Compare
tremarkley
force-pushed
the
09-23-feat_deploy_proxies
branch
from
0287404
to
551af9f
Compare
tremarkley
force-pushed
the
harry/superchain_weth_wrapper
branch
2 times, most recently
from
e62e3d1
to
4484eb9
Compare
tremarkley
force-pushed
the
09-23-feat_deploy_proxies
branch
from
551af9f
to
e50c7c3
Compare
tremarkley
force-pushed
the
harry/superchain_weth_wrapper
branch
2 times, most recently
from
dc865d8
to
26bdc7e
Compare
tremarkley
force-pushed
the
harry/superchain_weth_wrapper
branch
4 times, most recently
from
3a57c36
to
ca52ac7
Compare
tremarkley
changed the title
|
OH LETS GOOOOOO |
tremarkley
force-pushed
the
harry/superchain_weth_wrapper
branch
4 times, most recently
from
1e9f92c
to
09291d7
Compare
tremarkley
changed the title
SuperchainETHWrapper contract
tremarkley
force-pushed
the
harry/superchain_weth_wrapper
branch
2 times, most recently
from
8d24f0a
to
3ae91ae
Compare
tremarkley
commented
Sep 25, 2024
interop/relayer.go
Outdated
| @@ -119,16 +117,11 @@ func (r *L2ToL2MessageRelayer) Start(indexer *L2ToL2MessageIndexer, clients map[ | |||
| } | |||
| // Pad gas by 33%. | |||
| paddedGas := (gasEstimate / 3) + gasEstimate | |||
| mu.Lock() | |||
There was a problem hiding this comment.
this mutex lock does not work properly when multiple messages are sent in the same transaction. simplest way to fix this is to remove the lock and move the transactor within the case block
tremarkley
force-pushed
the
harry/superchain_weth_wrapper
branch
2 times, most recently
from
316bbc6
to
f269f4e
Compare
tremarkley
force-pushed
the
harry/superchain_weth_wrapper
branch
from
f269f4e
to
12e0c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #135
This contract facilitates sending ETH across chains within the Superchain by wrapping ETH into
SuperchainWETH, relaying theSuperchainWETHto the destination chain usingL2ToL2CrossDomainMessenger, and then unwrapping it back to ETH and sending it to the specified recipient on the destination chain.