-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate fix links #14832
Open
brossetti1
wants to merge
73
commits into
ethereum:dev
Choose a base branch
from
brossetti1:aggregate-fix-links
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Aggregate fix links #14832
+819
−845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bad dns config CNAME or A Record for WWW at eth magicians
…lly a bad dns config CNAME or A Record for WWW at https://ethresear.ch/
…pts/flash-loans - aave changed their website
…t-hooks-676d116eeae2 to https://www.apollographql.com/blog/apollo-client-now-with-react-hooks - apollographql removed hash from slugs
…docs.openzeppelin.com/contracts/5.x/wizard - 4.x wizard no longer available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content 🖋️
This involves copy additions or edits
translation 🌍
This is related to our Translation Program
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregate pr to fix broken links
Description
correcting broken links described here, if/when this is approved, you will probably want to squash and merge.
this pr specifically deals with this part of the issue:
submit 1 pr across all the links using my best judgement where its obviously a bad link and easy to discern the correct link, ie project name/domain changed (ie matic network is now polygon), external doc link changed pathing (saw this with some chainlink urls/aave redesigned their landing page so broken link just 404s), removing links for projects that no longer exist that have no associated content with the link -- basically all the obvious easy cleanups in 1 pr.
fyi the waybackmachine is truly an amazing public good.. i dont think it would be possible to go through these in a reasonable way without it.
Related Issue
#14823 (comment)
Changes
Im splitting these changes into two secctions below, the first one is a list of changes that are probably not exact matches for the fixed links as in the waybackmachine content of the broken link does not totally match the fixed link in the pr and therefore should probably be double checked for feedback by whoever is checking the pr. the changed links section is pretty much a one to one content match when compared against the broken link in the waybackmachine.
each commit has changes per broken link and the commit message typically follows this format (with variations as looking back i wasnt as consistent as i should of been.. oops) -
change [broken link] to [fixed link] - [options notes if available]
Aggregate PR should douoble check..
Changed Links
.html