Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean relative edit path before constructing url #14911

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Feb 14, 2025

Description

  • Passes relative path for edit button through the cleanPath function before constructing the edit URL

Related Issue

None filed. Fixes issue where index.md was being added to the relative path before removing any # hash links, resulting in bugs with the edit page links..

To reproduce:

  1. Go here: http://ethereum.org/en/developers/docs/accounts/#prerequisites
  2. "Edit page" button links to https://github.com/ethereum/ethereum-org-website/tree/dev/public/content/developers/docs/accounts/#prerequisites/index.md which is not quite correct.

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Feb 14, 2025
Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit bdd291f
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67afabf789ad390008c7fdf9
😎 Deploy Preview https://deploy-preview-14911--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 46 (🔴 down 5 from production)
Accessibility: 95 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines self-assigned this Feb 25, 2025
@corwintines corwintines merged commit c81d51a into dev Feb 25, 2025
6 checks passed
@corwintines corwintines deleted the fix-edit-path branch February 25, 2025 22:12
This was referenced Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants