Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evmmax: Implement modexp #1135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

evmmax: Implement modexp #1135

wants to merge 1 commit into from

Conversation

rodiazet
Copy link
Contributor

This PR implements expmod precompile using EVMMAX C++ API. The implementation restricts input sizes upper limit to 1024 bytes.

@rodiazet rodiazet force-pushed the modexp-evmmax-cpp branch 3 times, most recently from ad9dd5c to 94d4708 Compare February 18, 2025 12:14
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 98.95288% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.45%. Comparing base (d62977d) to head (8ddff48).

Files with missing lines Patch % Lines
test/state/precompiles.cpp 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1135      +/-   ##
==========================================
- Coverage   94.50%   94.45%   -0.06%     
==========================================
  Files         167      168       +1     
  Lines       18202    18037     -165     
==========================================
- Hits        17201    17036     -165     
  Misses       1001     1001              
Flag Coverage Δ
eof_execution_spec_tests 15.48% <0.00%> (+0.13%) ⬆️
ethereum_tests 27.21% <57.06%> (-1.11%) ⬇️
ethereum_tests_silkpre 21.13% <0.00%> (+0.30%) ⬆️
execution_spec_tests 19.95% <39.79%> (-1.14%) ⬇️
unittests 91.47% <83.76%> (+1.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone_precompiles/modexp.cpp 100.00% <100.00%> (ø)
test/unittests/evmmax_modexp.cpp 100.00% <100.00%> (ø)
test/state/precompiles.cpp 98.40% <90.47%> (-0.58%) ⬇️

@rodiazet rodiazet force-pushed the modexp-evmmax-cpp branch 5 times, most recently from dd3739b to fb40206 Compare February 19, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant