-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export int as hex for t8n env #1027
base: main
Are you sure you want to change the base?
Conversation
But this affects all exports. Do we have issues with that? |
I think the solution to this is not changing the |
XNumber type is to be exported as hex not Number in EnvironmentGeneric[XNumber] |
9a4e5fa
to
9ceacff
Compare
I just checked the failing unit test and it seems to be an error in EELS, so the change is breaking the interface. I think that we need to implement some changes in EELS before this change goes in, otherwise we might break test generation. Another thing is that I compared the generated fixtures for Cancun before and after this PR and there are some differences, so the change is somehow ending up in the fixtures too. |
Pushed a fix for an evm-tool unit test that was breaking on collection. Also the files in folder |
the fixtures were being generated with error in evmone because it treats all input as hex. to avoid potential issue in other t8n's this PR forcing the export in 0x format of geth |
4aa5c9f
to
a90ff1f
Compare
Could you point me to a particular json fixture where I can replicate the issue? |
@gurukamath try this command described in here |
7e919ff
to
f9becbd
Compare
ποΈ Description
Export values in it's hex representation when interacting with t8n
π Related Issues
#992
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.