feat(tests) Precompile Checks #1120
Conversation
reedsa
force-pushed
the
id-precompiles
branch
from
4ade831 to
ccb6574
Compare
There was a problem hiding this comment.
Gave this one a quick look and I wrote one comment.
We also have this similar test over here: https://github.com/ethereum/execution-spec-tests/blob/main/tests/frontier/precompiles/test_precompile_absence.py
| ["address", "exists"], | ||
| [ | ||
| ("01", True), | ||
| ("02", True), | ||
| ("03", True), | ||
| ("04", True), | ||
| ("05", True), | ||
| ("06", True), | ||
| ("07", True), | ||
| ("08", True), | ||
| ("09", True), | ||
| ("0A", True), | ||
| ("0B", False), |
There was a problem hiding this comment.
This list would only be valid for Cancun, but we could use this marker @pytest.mark.parametrize_by_fork to dynamically generate this list by fork.
I would also reduce the amount of cases to the first exists=False fork.
reedsa
force-pushed
the
id-precompiles
branch
from
ccb6574 to
473e19f
Compare
Those tests are very similar. Do you think it's still worth migrating these tests? |
| + Op.MSTORE(gas_test, Op.GAS()) | ||
| # Setup stack to CALL into precompile with the CALLDATA and CALL into it (+ pop value) | ||
| + Op.CALL( | ||
| address=Op.CALLDATALOAD(0), |
There was a problem hiding this comment.
Trying to pass in the precompile address in the data of the transaction for this call. It doesn't seem like I can pass the correct value from the bytes value passed, even if I try to convert the value from the CALLDATALOAD to an integer. Is there a recommendation for how to approach this?
There was a problem hiding this comment.
here the data must be padded as EVM word of 32 bytes. so not enough just fromhex(1 byte) you need to padd it with zeros to the left. like Hash32(data, left_padding=true)
reedsa
force-pushed
the
id-precompiles
branch
3 times, most recently
from
dfbf4c6 to
f78c534
Compare
|
@winsvega @marioevz now I have the data (precompile address) being sent into the transaction. It looks like all tests are returning 0 however. Is there something I may have missed with the logic in the contract? In the original test, the gas cost difference is found based on a condition that the precompile gas is greater than the gas for the call at the address |
|
|
||
| """ | ||
| return [ | ||
| ("01", True), |
There was a problem hiding this comment.
you can access fork class from the test if you add fixture in the parameter list.
fork: Fork
and then it has a function that returns all precompiles currently active on that fork as integer list.
| if_false=Op.SUB(Op.MLOAD(gas_10000), Op.MLOAD(gas_test)), | ||
| ), | ||
| ) | ||
| + Op.SSTORE(0, Op.LT(Op.SLOAD(0), 0x10)) |
There was a problem hiding this comment.
here also a pattern we use. there is class Storage.
so you can call Op.SSTORE(storage.store_next(expected_value, "debug hint"), logic)
reedsa
force-pushed
the
id-precompiles
branch
2 times, most recently
from
0cb561c to
d2cab4a
Compare
Check each fork for valid precompiles Only verify absence of precompile for one address
reedsa
force-pushed
the
id-precompiles
branch
from
d2cab4a to
e43edba
Compare
|
@marioevz @winsvega Latest revisions are creating parameterized tests for each fork with valid precompiles as well as a single invalid precompile. I noticed the gas cost is slightly higher than what the original tests were using. Instead of the gas being compared with This however fails with Byzantium and Constantinople for precompile 5 and I'm not sure why. |
|
I think the tes was not designed for that forks. Check in ethereum/legacytests if it has a revision for other forks. But yes, need to understand what's going on |
🗒️ Description
Add tests to check each precompile at specific addresses.
Tests from: https://github.com/ethereum/tests/blob/develop/src/GeneralStateTestsFiller/stPreCompiledContracts/idPrecompsFiller.yml
🔗 Related Issues
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.