cmd/abigen: either --abi or --combined-json should be required.
#30768
Assignees
Labels
Comments
|
Hey @jwasinger. I am still familiarizing myself with the project but I would like to work on this if possible. Looking forward to your thoughts! |
jwasinger
changed the title
--abi flag should be required.--combined-json or --abi should be required. they should be mutually-exclusive.
jwasinger
changed the title
--combined-json or --abi should be required. they should be mutually-exclusive.--combined-json or --abi should be required. they should be mutually-exclusive.
jwasinger
changed the title
--combined-json or --abi should be required. they should be mutually-exclusive.--combined-json or --abi should be required.
jwasinger
changed the title
--combined-json or --abi should be required.--abi or --combined-json should be required.
MariusVanDerWijden
pushed a commit
that referenced
this issue
Jan 20, 2025
This PR addresses issue #30768 , which highlights that running cmd/abigen/abigen --pkg my_package example.json (erroneously omitting the --abi flag) generates an empty binding, when it should fail explicitly. --------- Co-authored-by: jwasinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Opening this to remind myself to ensure it's fixed.
Running
cmd/abigen/abigen --pkg my_package example.json(erroneously omitting the--abiflag) generates an empty binding. Ifabigenis run without specifying--combined-jsonor--abi, it should fail explicitly.The text was updated successfully, but these errors were encountered: