cmd/abigen: make one of --abi or --combined-json be required
#31045
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
reviewed
Jan 19, 2025
…t least one of them to be set.
jwasinger
changed the title
--abi or --combined-json be required. make them mutually exclusive
jwasinger
reviewed
Jan 19, 2025
jwasinger
changed the title
--abi or --combined-json be required. make them mutually exclusive--abi or --combined-json be required
jwasinger
approved these changes
Jan 19, 2025
rjl493456442
approved these changes
Jan 20, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 21, 2025
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 21, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #30768 , which highlights that running cmd/abigen/abigen --pkg my_package example.json (erroneously omitting the --abi flag) generates an empty binding, when it should fail explicitly.
Changes
--abi flag is now mandatory when running abigen command and fail explicitly if it is missing
If theses changes are good, I’d be happy to continue familiarizing myself with the project and contributing to it!