Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError in insert_node_before #15913

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Pricstas
Copy link

@Pricstas Pricstas commented Mar 8, 2025

This PR fixes a bug in insert_node_before where child.parent.insert(position, new_sibling) was incorrectly used.
Since docutils.nodes.Element does not have an insert method, the correct approach is to insert the new sibling into the children list instead.

Changes

  • Replaced child.parent.insert(position, new_sibling) with child.parent.children.insert(position, new_sibling), ensuring proper insertion of nodes.

Copy link

github-actions bot commented Mar 8, 2025

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant