Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx: rename method names (remove EIP word) #3597

Merged
merged 1 commit into from
Aug 16, 2024
Merged

tx: rename method names (remove EIP word) #3597

merged 1 commit into from
Aug 16, 2024

Conversation

jochem-brouwer
Copy link
Member

This PR does one thing and that is to remove the EIP word from the Tx library methods and classes. (Also renames constructors as create7702EOACodeTx to createEOACode7702Tx)

I have only used "find-and-replace" so if CI passes this should be fine.

To quickly test the renames, build the library, and then in node require('@ethereumjs/tx') and verify the output names of the exported methods/classes.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 6.74%. Comparing base (4470cc3) to head (3e96cac).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block ?
client 0.00% <0.00%> (ø)
common 89.68% <ø> (?)
tx ?
wallet ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and reads absolutely great! 🤩

Will merge.

@holgerd77 holgerd77 merged commit 2563fb8 into master Aug 16, 2024
34 of 36 checks passed
@holgerd77 holgerd77 deleted the tx-renames branch August 16, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants