monorepo: convert test data from JSON to objects #3642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thereumjs/ethereumjs-monorepo into monorepo/typescript-test-files
holgerd77
reviewed
Sep 9, 2024
| block_number: string | ||
| gas_limit: string | ||
| gas_used: string | ||
| timestamp: string |
There was a problem hiding this comment.
Through this work I realized that these values are actually numeric string, not 0xprefixed strings. See for e.g.
There was a problem hiding this comment.
Created a numeric string type for it
There was a problem hiding this comment.
Oh, that's super cool (so: the new type)! Again on this level, small change, but really another typing milestone in our libraries, once we have applied this consistently throughout the libraries! 🤩
|
🙏 |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins addressing #3637 by converting JSON test data to objects.
The packages fully converted by this PR are:
Some other packages have been partially migrated because of cross-dependencies.