Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: update the system contract addresses for prague devnet4 #3706

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Sep 27, 2024

refrence:

https://github.com/ethpandaops/ethereum-genesis-generator/pull/143/files

update withdrawal and consolidation requests system contract addresses for devnet4

@jochem-brouwer
Copy link
Member

jochem-brouwer commented Sep 27, 2024

Can we use this PR as devnet-4 branch and not merge this until devnet-4 is specced out completely?

Ref for further additions: ethereum/execution-spec-tests#832

Devnet-4 spec https://notes.ethereum.org/@ethpandaops/pectra-devnet-4

@g11tech
Copy link
Contributor Author

g11tech commented Sep 27, 2024

yes apparently the address specified in the 7002 eip and in the genesis generator changes don't match
cc @parithosh

in EIP:
image

in genesis generator PR:
image

@parithosh
Copy link

ah there's probably an update missing. lemme me clear that up and get back to you!

@g11tech
Copy link
Contributor Author

g11tech commented Sep 27, 2024

are you sure @g11tech ?

EIP update was merged in: https://github.com/ethereum/EIPs/pull/8890/files#diff-70472fac1debb567783ce13873323261713f3ce488a26a5c3769a9193f4a7e27R521

which is the address we used in the genesis generator: https://github.com/ethpandaops/ethereum-genesis-generator/pull/143/files#diff-e563a01282cd9e2db47dceb99a9337f1f37466f6bfe5d10b376435d51f179f34R114

yes i am sure as of the current published EIP :)

image

as well as latest github file

image

@jochem-brouwer
Copy link
Member

I just manually checked the EIP-7002 data, I get this:

sender: 0xac6afb9d8491e8b397f65331ce41e338cbfe1048
contract address: '0x0511ce19514e1298fba96de582652a016e2caaaa'

@jochem-brouwer
Copy link
Member

@parithosh I just saw that the address got updated again in this commit: ethereum/EIPs@a23be81

In this PR:
ethereum/EIPs#8855

This changed code, so it also changed the address. (I assume this is included in devnet-4?)

@@ -78,7 +78,7 @@ export const paramsVM: ParamsDict = {
7002: {
// config
systemAddress: '0xfffffffffffffffffffffffffffffffffffffffe', // The system address to perform operations on the withdrawal requests predeploy address
withdrawalRequestPredeployAddress: '0x00A3ca265EBcb825B45F985A16CEFB49958cE017', // Address of the validator excess address
withdrawalRequestPredeployAddress: '0x05F27129610CB42103b665629CB5c8C00296AaAa', // Address of the validator excess address
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the address of this commit: ethereum/EIPs@1335765

The latest commit (which shows up on eips.ethereum.org) is ethereum/EIPs@a23be81 pointing to 0x0511Ce19514e1298Fba96de582652A016E2CAaAa

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes @parithosh mentioned there are a few more updates coming through, so we gotta hold on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants