Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: return tags for uploads #408

Merged
merged 7 commits into from
Sep 3, 2021
Merged

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented Aug 31, 2021

Closes #366

Breaking changes:

  • Changes the returned type to UploadResult interface for all uploading methods like: uploadData(), uploadFile(), uploadFilesFromDirectory(), uploadFiles()

Other changes:

  • Introduces uploadCollection() method

src/feed/json.ts Outdated Show resolved Hide resolved
src/feed/json.ts Outdated Show resolved Hide resolved
src/types/index.ts Outdated Show resolved Hide resolved
src/utils/http.ts Outdated Show resolved Hide resolved
test/integration/bee-class.spec.ts Outdated Show resolved Hide resolved
@AuHau AuHau requested a review from nugaon September 1, 2021 10:22
@nugaon
Copy link
Member

nugaon commented Sep 2, 2021

Please remove the @web-std/file from the devDeps as well.

@AuHau AuHau merged commit e58b8e8 into master Sep 3, 2021
@AuHau AuHau deleted the feat/return-tags-for-uploads branch September 3, 2021 06:01
@bee-worker bee-worker mentioned this pull request Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags are automatically created - should we automatically return them?
2 participants