Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger subscribe push to ensure new iteration #4204

Merged
merged 1 commit into from
Jul 3, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/storer/subscribe_push.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ func (db *DB) SubscribePush(ctx context.Context) (<-chan swarm.Chunk, func()) {
db.logger.Error(err, "subscribe push: iterate error")
return
}
// if we get storage.ErrNotFound, it could happen that the previous
// iteration happened on a snapshot that was not fully updated yet.
// in this case, we wait for the next event to trigger the iteration
// again. This trigger ensures that we perform the iteration on the
// latest snapshot.
db.events.Trigger(subscribePushEventKey)
}

select {
Expand Down
Loading