Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations First Draft #56

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Annotations First Draft #56

wants to merge 9 commits into from

Conversation

PaulRBerg
Copy link
Contributor

Related to #20. A few notes/ questions:

  • The annotations page is the 3rd item on the nav bar of the "Learn" tab, let me know if you think there's a better place for it
  • I added a bunch of explanatory links as tags, but, as per your 4th point in the OP, I was also thinking that these could be references at the bottom of the page (like in a LaTeX document) to make them stand out
  • Regarding "Miscellaneous/ Bitmaps", I really couldn't find any documentation on it. Just pasting the question from html, but are these bitmaps key-value pairs, where the keys map to the balances on the root chain contract and the values are binary?
  • The "Active Development" section will be completed soon (it won't be that bulky), but I wanted to check in and make sure everything's fine up to this point (structure, layout, idea ordering). Also, is it okay to include a couple of examples in this chapter? E.g. OmiseGo's DEX.

@smartcontracts
Copy link
Member

Sorry for the delay on reviewing this. Can we rebase to master and revert some of the minor changes (packagelock.json, shifting everything over with tabs)? It creates a very large diff and hard to review. We can add those changes back in with another PR later.

@PaulRBerg
Copy link
Contributor Author

No worries! I aim to rebase and revert the changes soon.

@PaulRBerg
Copy link
Contributor Author

Hey @kfichter, this is done and it only needs your final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants