Fix $gp calculation when addiu value is negative (#393)

* Fix $gp calculation when addiu value is negative * black * Use getProcessedImmediate * Bump version to 0.25.3
ethteck · Aug 10, 2024 · e2a638e · e2a638e
1 parent f37e767
commit e2a638e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # splat Release Notes
 
+### 0.25.3
+
+* Fix incorrect calculation for `$gp` value in create_config.py for PSX when immediate value is negative.
+
 ### 0.25.2
 
 * Two new yaml options: `use_gp_rel_macro_nonmatching` and `use_gp_rel_macro`

diff --git a/README.md b/README.md
@@ -21,7 +21,7 @@ The brackets corresponds to the optional dependencies to install while installin
 If you use a `requirements.txt` file in your repository, then you can add this library with the following line:
 
 ```txt
-splat64[mips]>=0.25.2,<1.0.0
+splat64[mips]>=0.25.3,<1.0.0
 ```
 
 ### Optional dependencies

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,7 +1,7 @@
 [project]
 name = "splat64"
 # Should be synced with src/splat/__init__.py
-version = "0.25.2"
+version = "0.25.3"
 description = "A binary splitting tool to assist with decompilation and modding projects"
 readme = "README.md"
 license = {file = "LICENSE"}

diff --git a/src/splat/__init__.py b/src/splat/__init__.py
@@ -3,7 +3,7 @@
 __package_name__ = __name__
 
 # Should be synced with pyproject.toml
-__version__ = "0.25.2"
+__version__ = "0.25.3"
 __author__ = "ethteck"
 
 from . import util as util

diff --git a/src/splat/util/psx/psxexeinfo.py b/src/splat/util/psx/psxexeinfo.py
@@ -136,9 +136,9 @@ def try_get_gp(rom_bytes, start_offset, max_instructions=50) -> int:
             break
         insn = rabbitizer.Instruction(word)
         if insn.getOpcodeName() == "lui" and insn.rt.name == "gp":
-            gp = insn.getImmediate() << 16
+            gp = insn.getProcessedImmediate() << 16
         elif insn.getOpcodeName() == "addiu" and insn.rt.name == "gp":
-            gp += insn.getImmediate()
+            gp += insn.getProcessedImmediate()
             break
     return gp