Secure area definitions and key management functionality #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the secure area key options and purpose. It introduces a new file `KeyOptions.swift` that defines the tasks for which keys can be used, such as signing and key agreement. It also adds a new enum `KeyAccessProtection` to specify the condition for the key to be available. Additionally, the `KeyPurpose.swift` file has been deleted as it is no longer needed.
…ce and requirePassword in KeyAccessControl struct
…f ECCurveType Refactor the CoseKey and CoseKeyPrivate structs in the CoseKey.swift file to use the CoseEcCurve enum instead of the ECCurveType enum. This change ensures consistency and clarity in the codebase. Refactor DeviceEngagement to use CoseEcCurve enum in initializer Refactor the DeviceEngagement struct in the DeviceEngagement.swift file to use the CoseEcCurve enum in the initializer instead of the ECCurveType enum. This change improves code readability and maintainability. Update CoseEcCurve to use UInt64 raw value type Update the CoseEcCurve enum in the CoseEcCurve.swift file to use UInt64 as the raw value type instead of Int. This change aligns with the COSE registry and ensures compatibility with iOS natively supported curves. Refactor KeyOptions.swift to use requireApplicationPassword instead of requirePassword Refactor the KeyOptions.swift file to use the requireApplicationPassword property instead of the requirePassword property in the KeyAccessControl struct. This change improves clarity and consistency in the codebase.
…ter name for curve
…ity and maintainability
…lockData parameter
…and unlocking methods
… and improve key management functionality
…ance key management and support actor-based concurrency
…tor model for improved concurrency and key management
…n to simplify signature method and improve code clarity
…n to adopt actor model and support async operations
vkanellopoulos
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secure area definitions and refactor key management structures. Introduce new protocols and enums to streamline key access and management, while ensuring compatibility with existing cide.