Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

233 added swr and removed useEffects #269

Merged
merged 47 commits into from
Dec 17, 2023
Merged

233 added swr and removed useEffects #269

merged 47 commits into from
Dec 17, 2023

Conversation

mountclear
Copy link
Collaborator

No description provided.

@mountclear mountclear linked an issue Nov 20, 2023 that may be closed by this pull request
Closed
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (9eb8a32) 91.11% compared to head (fc59ff6) 87.27%.
Report is 42 commits behind head on development.

Files Patch % Lines
backend/dbtools/sortby.go 40.42% 26 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #269      +/-   ##
===============================================
- Coverage        91.11%   87.27%   -3.84%     
===============================================
  Files               11       12       +1     
  Lines              360      393      +33     
===============================================
+ Hits               328      343      +15     
- Misses              25       42      +17     
- Partials             7        8       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mountclear mountclear requested a review from euanwm November 21, 2023 20:33
@mountclear
Copy link
Collaborator Author

@euanwm can you check if the league submisson form works on your locally as i get cors error

@euanwm
Copy link
Owner

euanwm commented Nov 21, 2023

@mountclear Going to hold off on this as @rsbrowne has done a bunch of work that'll clash with this. I'm also changing the backend API for the main leaderboard.

@rsbrowne
Copy link
Collaborator

Yeah apologies, I really should have commented somewhere that I was overhauling the site to use the new App routing in Next 13

@mountclear
Copy link
Collaborator Author

@euanwm @rsbrowne
|ok cool i'll update the PR after the update on development branch later.

sjdoescoding and others added 24 commits December 15, 2023 01:16
indentation
Testing cron schedule
push commit, PR any changes
changed to on push
Action run on Fri Dec 15 15:45:17 UTC 2023
checking if:always()
Action run on Fri Dec 15 15:55:54 UTC 2023
Final, PR not working entirely but heck
reverted to original function
Action run on Fri Dec 15 16:14:36 UTC 2023
changed repo to euanwm and scheduled for midnight everyday
Automated DB Update & String Conversion for check_db.py
@mountclear mountclear requested a review from rsbrowne as a code owner December 17, 2023 20:57
@euanwm euanwm merged commit 88cfa1e into development Dec 17, 2023
9 of 11 checks passed
@euanwm euanwm deleted the 233-swr-two branch December 17, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SWR
4 participants