Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add total results #270

Merged
merged 6 commits into from
Nov 26, 2023
Merged

Feature/add total results #270

merged 6 commits into from
Nov 26, 2023

Conversation

euanwm
Copy link
Owner

@euanwm euanwm commented Nov 25, 2023

Major breaking change to the leaderboard API endpoint to allow for the total amount of lifters to be known in a filter query.

Schema:

{
    "size": int,
    "data": [{lift_data_1}, {lift_data_2}, {lift_data_etc}],
}

@euanwm
Copy link
Owner Author

euanwm commented Nov 25, 2023

@mountclear / @rsbrowne - It is done.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (9eb8a32) 91.11% compared to head (8c98c3f) 87.27%.

Files Patch % Lines
backend/dbtools/sortby.go 40.42% 26 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #270      +/-   ##
===============================================
- Coverage        91.11%   87.27%   -3.84%     
===============================================
  Files               11       12       +1     
  Lines              360      393      +33     
===============================================
+ Hits               328      343      +15     
- Misses              25       42      +17     
- Partials             7        8       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@euanwm euanwm merged commit ac9071a into development Nov 26, 2023
9 of 11 checks passed
@euanwm euanwm deleted the feature/add_total_results branch November 26, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant