-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated DB Update & String Conversion for check_db.py #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
development yeet
testing at 10 midnight
updated line 60 beyond
testing
changed --update all
verbose argument catcher incase no arguments provided i.e. --update all
line 62, added a function to replace empty strings with '0.0'
testing
changed float to 0
testing
further fixing empty results
indentation
testing
Testing cron schedule
push commit, PR any changes
updated
changed to on push
Action run on Fri Dec 15 15:45:17 UTC 2023
testing
checking if:always()
Action run on Fri Dec 15 15:55:54 UTC 2023
Final, PR not working entirely but heck
reverted to original function
Action run on Fri Dec 15 16:14:36 UTC 2023
changed repo to euanwm and scheduled for midnight everyday
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #277 +/- ##
============================================
Coverage 87.27% 87.27%
============================================
Files 12 12
Lines 393 393
============================================
Hits 343 343
Misses 42 42
Partials 8 8 ☔ View full report in Codecov by Sentry. |
euanwm
reviewed
Dec 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened issue #278 as a result
euanwm
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR function of the workfile hasn't been fully tested, but should be fairly easy to edit so it PRs the development branch for merging (like 1-2 lines of code).