Config file #153
Closed
Config file #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2db631e.
…ow all are positive. For reasoning, see ray-project/ray#4374
Added localconfig requirement. Many user-specific and experiment-specific parameters have been moved to the config file. Renamed train scripts to have consistent names. Now follows the convention: train_[experiment]_[algorithm].py Experiment results are written to folders with the following naming convention: [experiment]_[algorithm]_[environment], where environment is either cleanup or harvest. Removed train_baseline as it is redundant with train_baseline_a3c.
Removed exp_name check, as this is now always handled by config_parser.
Simplified access to hyperparameters.
|
Additionally, I imagine some train_* files can be merged when parametrized, there's a lot of duplicate code in there. Separating the experiment categories (baseline, visible actions, influence, moa) from their algorithms (A3C, A2C, DQN) so they can vary independently would be ideal, although I'm not sure whether it's easy to do. |
… file. Curriculum is not used yet, as it does not cleanly map to a single parameter. Made some numbers more clear (100e6 -> 1e8) Renamed train_influence_a3c to train_influence_moa. Renamed train_moa_a3c to train_moa_baseline.
|
These changes are all very outdated, and I'm getting rid of config_parser in my fork. Thus, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the config file as mentioned in #151.
4 questions:
I haven't reproduced the results from the paper yet. Currently it takes me 6 days to take the 3e8 steps required per experiment - I'm in the process of requesting more powerful hardware.