Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reindex managerRolesAndUsers when managing ldap users #284

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Reindex managerRolesAndUsers when managing ldap users #284

merged 1 commit into from
Sep 16, 2024

Conversation

reinhardt
Copy link
Contributor

Note that the index is not updated when assigning permissions in another way. Hoping that this is enough for osha.

Ref syslabcom/scrum#2640

@reinhardt reinhardt requested a review from thet September 16, 2024 14:12
thet
thet approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sure that the reindex is done after changing object permissions and scrum-2640 is done?
LGTM

@reinhardt
Copy link
Contributor Author

It's independent of #283, if that's what you mean. #284 is the main fix, #283 only changes the indexed values to be less confusing.

@reinhardt reinhardt merged commit 6e45502 into main Sep 16, 2024
2 checks passed
@reinhardt reinhardt deleted the scrum-2640-reindex-manage-ldap-users branch September 16, 2024 14:55
@reinhardt reinhardt mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thet thet thet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reinhardt @thet