Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailing lists: Stable sorting #301

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

reinhardt
Copy link
Contributor

Stable sorting is necessary to make batching work reliably.

Ref https://github.com/syslabcom/scrum/issues/2316

Stable sorting is necessary to make batching work reliably.

Ref syslabcom/scrum#2316
@reinhardt reinhardt requested a review from thet January 14, 2025 09:36
@reinhardt reinhardt marked this pull request as draft January 14, 2025 09:44
@reinhardt
Copy link
Contributor Author

Hold on, I'll add another fix.

There are multiple tools with the same title in different countries, e.g. "Agriculture".
For batching we need to make sure they are always sorted in the same
way.

Ref syslabcom/scrum#2316
@reinhardt reinhardt marked this pull request as ready for review January 14, 2025 09:57
@reinhardt
Copy link
Contributor Author

OK, ready!

Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reinhardt reinhardt changed the title Mailing lists: Sort language-specific entries Mailing lists: Stable sorting Jan 14, 2025
@reinhardt reinhardt merged commit c6e6735 into main Jan 14, 2025
1 check passed
@reinhardt reinhardt deleted the scrum-2316-mailing-lists-sorting branch January 14, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants