Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML batch_2 update #101

Merged
merged 40 commits into from
Apr 9, 2024
Merged

YAML batch_2 update #101

merged 40 commits into from
Apr 9, 2024

Conversation

FedericoRondoni
Copy link
Contributor

@FedericoRondoni FedericoRondoni commented Feb 23, 2024

E10a1_agricultural_production_productive_area E10a2_agricultural_production_area E10a3_agricultural_production_area_change E10a10_harvesting_evolution E10a5_fruit_production E10a6_harvested_parcels_evolution E10a8_winter_cereals E10a9_agricultural_workers E11_shopping_center_activity

@FedericoRondoni
Copy link
Contributor Author

Hi @santilland could you check why there is the error on the checks?
I cannot find the reason why it fails during the built of the E10a10 indicator.
Thanks!

@santilland
Copy link
Collaborator

Strange, locally it seems to run fine, might be a connection issue to one of the services, i will try to rerun

@santilland
Copy link
Collaborator

seems to throw always the same error, searching a bit for potential issues i found:
Windows style newline characters can cause issues in Cygwin
I will try to check the new line format in the file

@santilland
Copy link
Collaborator

@FedericoRondoni could you push another small change? Is it possible you had a line break in the pull request first comment before?
If yes, maybe your edit fixed it, if not, i can't really think of why it is not working. The build works fine locally.

@FedericoRondoni
Copy link
Contributor Author

@santilland yes, it might be that. How can we solve it?

@lubojr
Copy link
Member

lubojr commented Feb 26, 2024

@FedericoRondoni I'm afraid that after you've edited the PR comment, you need to push a new commit (with some, even tiny changes) to trigger the automatic workflow with the new PR comment applied.

For us rerunning a past workflow would take the PR comment in the original form in the past.

@FedericoRondoni
Copy link
Contributor Author

Hi @santilland and @lubojr now it worked 😊
Thanks!

@FedericoRondoni
Copy link
Contributor Author

@dmoglioni

- ESA
- ESA
Provider:
- Name: Copernicus
Copy link
Contributor

@aapopescu aapopescu Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FedericoRondoni , actually this indicator is provided by VISTA in a study funded by ESA:
The study is “Impact of COVID-19 on Harvest of Row Crops” conducted by [VISTA Remote Sensing in Geosciences GmbH] and funded by the European Space Agency.

- EndPoint: https://xcube-geodb.brockmann-consult.de/eodash/6bf15325-f6a0-4b6a-bf80-a2491753f8f2/
Name: GeoDB
Database: eodash
CollectionId: E10a10
Copy link
Contributor

@aapopescu aapopescu Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FedericoRondoni , Please add

References:

Provider:
- Name: FAO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FedericoRondoni , this indicator was produced by UCL https://uclouvain.be/en/index.html, please update provider.

Provider:
- Name: FAO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FedericoRondoni provider is UCL, same comment as for E10a2

Provider:
- Name: FAO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FedericoRondoni , provider is UCL, same comment as in E10a1

@santilland
Copy link
Collaborator

Here is also the link to see it in the client:
https://eodash-testing.eox.at/ui-panels-cat/?catalog=YAML-batch_2
(Still to be done, the collapsible header will be removed for entries with only one item)

- ESA
- ESA
- CNES
Provider:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provider of the dataset is UCL https://uclouvain.be/en/index.html

Agency:
- ESA
- ESA
Provider:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indicator provided by Sistema https://sistema.at/

Copy link
Contributor

@aapopescu aapopescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FedericoRondoni please address the comments in the yamls

- Traffic
- Open data
DataSource:
Spaceborne:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add also the source VODAFONE for non-satellite data

@@ -2,32 +2,37 @@ Name: parking_lot_volume
Title: Parking lot volume
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REMOVE THIS ---> we move the content into a story

@FedericoRondoni
Copy link
Contributor Author

@FedericoRondoni please address the comments in the yamls

I think I have done it. I'm not sure I know how to handle a change request in GitHub, but the files should be good now

@lubojr lubojr merged commit 5d07275 into main Apr 9, 2024
1 check passed
@lubojr lubojr deleted the YAML-batch_2 branch April 9, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants