Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connman_curses doesn't make clear which wireless interface is using when two or more wireless interfaces are available #5

Merged
merged 1 commit into from
Apr 7, 2015

Conversation

alan-mushi
Copy link
Contributor

Hello,

Recently I've started using connman_curses with two wireless interfaces simultaneously and I've found some confusing behaviors (they may be only confusing to me). I'll open a ticket per issue and you'll see if it's a real problem or not =). The first one is, when two or more wireless interfaces are available (it may be applicable to other technologies) connman_curses doesn't make clear which interface is using.

Testcase

  1. Make available two or more wireless interfaces to the system
  2. Disconnect from all wireless networks
  3. Launch connman_curses
  4. Select the wifi technology
    • connman_curses shows repeated some APs and doesn't specify which interface detects which AP and therefore I have no way to select conscientiously which interface connects to a specific AP.

0yk8cein

In the above image some AP essids are repeated, eg. INFINITUMl8p4 , not all of them are repeated because one of the wireless interfaces is more sensitive than the other.

Expected behavior

I think connman_curses should state which wireless interface is detecting which AP or should list only once every AP detected if no specification is displayed, in that case it should use the interface with better range detection by default.

@alan-mushi
Copy link
Contributor

Hi,

Again, see #6, it's more connman's job: connman status signals (used to update/display the services/AP list) don't include which interface detected the AP.
Seeing the AP twice is absolutely normal : connman don't group services on any criteria.

@pfl
Copy link

pfl commented Feb 2, 2015

Take a look at the 'Ethernet' property in the ConnMan service API to distinguish between devices/MAC addresses.

@pfl
Copy link

pfl commented Feb 2, 2015

BTW, the string 'psk' actually means WPA/WPA2 in plaintext.

@jobol
Copy link
Contributor

jobol commented Feb 2, 2015

@pfl thank you for the hint! finding that wifi's interface is in the ethernet field is not obvious for sure. experts are very welcome.

@alan-mushi
Copy link
Contributor

Will something like this do ? The preposterously long eSSID will be truncated (it can be 32 chars in the standard but we have to reduce it to 23 chars to make it fit on the smallest screen resolution).

interface name in services list

I can't test nor show this with multiple interfaces because I only have one...

@javier-lopez
Copy link
Contributor Author

From my point of view it's enough =). I couldn't stop however noticing the blank spaces in the signal strength field, would make sense to take the required chars from that field so the essid field can display the whole names? The state field has a good amount of empty spaces too.

I can help testing multiple interfaces (is there a branch from where to pull these modifications?)

Thanks for your continue support.

@alan-mushi
Copy link
Contributor

the blank spaces in the signal strength field

Yes I can steal some spaces there by renaming "Signal strength" to "Signal" so the alignment is kept.

The state field has a good amount of empty spaces too.

We can't touch these ones, the state string can be quite long connman doc.

I can help testing multiple interfaces (is there a branch from where to pull these modifications?)

Thanks ! I will put them there alan-mushi/connman-json-client branch issue5.

@alan-mushi alan-mushi self-assigned this Feb 18, 2015
@javier-lopez
Copy link
Contributor Author

Awesome, this is how it looks in my setup. It seems like the security field is talking a little bit more space that what it should but besides that, it works =). Thanks!

irpppogd

@jobol
Copy link
Contributor

jobol commented Feb 19, 2015

I agree that security field is much cryptic

@alan-mushi
Copy link
Contributor

Yes I agree (there was a reserve/note in the commit about this), We can "gain" 4 char by removing [ and the symmetric.
@chilicuil I pushed this modification and my nearby networks don't have multiple entries for the security array, could you try and post the picture please ?

@javier-lopez
Copy link
Contributor Author

Now it's aligned quite fine =). Thanks!

lifs1mwo

@alan-mushi
Copy link
Contributor

@jobol Is there a problem with this PR ? If it's about the length of the "security" field I might be able to glean some characters here and there but in the end the minimal screen resolution is fairly small.

jobol added a commit that referenced this pull request Apr 7, 2015
@alan-mushi No problem with the submission and happy to merge it :)
@jobol jobol merged commit f6e5978 into eurogiciel-oss:master Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants