Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move CTF assets plugin to utils #2362

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rwd
Copy link
Contributor

@rwd rwd commented Jun 12, 2024

  • move Contentful assets helper functions from contentful module/plugin to a utils library
  • rename exported functions to include "contentful"
  • remove contentful store module
    • was used to detect and store the client's accepted image formats to only return WebP when they support it, but the browser versions we target all do support WebP, so it's extraneous
    • i.e. always return WebP unless format is specified or original is an SVG

@rwd rwd marked this pull request as ready for review June 12, 2024 09:37
Copy link

Preview deployment: https://pr-2362.portal-js.dev.eanadev.org/

Copy link

sonarcloud bot commented Jun 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant