Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate bodygrey background #2425

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat: deprecate bodygrey background #2425

wants to merge 9 commits into from

Conversation

LeoniePeters
Copy link
Contributor

@LeoniePeters LeoniePeters commented Aug 22, 2024 •
edited
Loading

  • Deprecated the white-page class
    • Sets the default body background-color to white
    • Cleans up separate white/bodygrey styles for ContentPrimaryCallToAction component
  • Aligns the top page spacing across pages
  • Removes container, row, col wrappers from gallery header as it's not needed and adds superfluous spacing
  • Renames various scss color variables for grey tones

@LeoniePeters LeoniePeters added the work in progress Work in progress, not yet ready to be merged label Aug 22, 2024
@github-actions GitHub Actions
Copy link

JIRA ticket: EC-6896

@github-actions GitHub Actions
Copy link

Preview deployment: https://pr-2425.portal-js.dev.eanadev.org/

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@LeoniePeters LeoniePeters removed the work in progress Work in progress, not yet ready to be merged label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LeoniePeters