Added sequence tests #27

ericlesaquiles · 2018-07-17T23:56:18Z

No description provided.

Affonso-Gui · 2018-07-19T02:12:23Z

auxiliary/ansi-aux.lsp

@@ -1024,10 +1024,10 @@ the condition to go uncaught if it cannot be classified."
  "Create a test that FORM, which should produce a fresh value,
   does not improperly introduce sharing during constant folding."
  `(deftest ,name
-     (flet ((%f () (declare (optimize (speed 3) (safety 0) (space 0)


Should work when loading from eus-test.l

https://github.com/euslisp/ansi-test/blob/gsoc2018/eus-test.l#L102

Affonso-Gui · 2018-07-19T02:18:17Z

Are you using euslisp from source or from apt?
Bit vectors should have been fixed in euslisp/EusLisp#281, make sure you have it to run bit-vector tests.

Also, it appears that the latest euslisp requires building roseus from source too in Ubuntu 16 euslisp/EusLisp#291. Let us know if you have any problems with that.

ericlesaquiles · 2018-07-20T18:29:28Z

I thought I was using the latest version (roseus was 1.7, if I'm not mistaken), but it might've slipped. Now, is it just me or there is no more roseus from apt (sudo apt install ros-kinetic-roseus doesn't work anymore)?

Anyway, I'm using euslisp from source now. But, after uninstalling roseus, I've been unable to bring it back (installation fails, mostly because it can't find euslisp's ros configuration files, which were removed prior to installing from source.. I've tried some changes on roseus's installation files to try to circumvent that, but none worked).

ericlesaquiles · 2018-07-20T18:55:19Z

Now, with euslisp from source, when running the tests I'm having unbound variable mtimer. Do you have some idea on what that might be? I have found no reference to mtimer either on euslisp's source code or on the manual..

Affonso-Gui · 2018-07-21T13:46:40Z

I was able to run from source with the following:

git clone https://github.com/euslisp/jskeus.git
cd jskeus
make
source bashrc.eus

cd /path/to/workspace/src
git clone https://github.com/jsk-ros-pkg/jsk_roseus.git

>> change $(euslisp_INCLUDE_DIRS) to the path to jskeus/eus/include in include_directories() line of jsk_roseus/roseus/CMakeLists.txt

cd /path/to/workspace
catkin build roseus
source devel/setup.bash

Affonso-Gui · 2018-07-21T13:52:53Z

I get no errors at mtimer, but the test stops at peek-char.1. We might need to have a look at that.

ericlesaquiles · 2018-07-21T17:02:46Z

I did the changes you mentioned (even when probably not needed):

if(APPLE)
-  if(NOT EXISTS /usr/local/opt/jskeus/eus)  # $EUSDIR in OS X
+  if(NOT EXISTS /home/ericles/Projetos/JSK/jsk-projects/jskeus/eus)  # $EUSDIR in OS X
     message(FATAL_ERROR "jskeus is not installed via Homebrew, Please run `brew install homebrew/x11/jskeus`")
   endif()
-  set(euslisp_INCLUDE_DIRS /usr/local/opt/jskeus/eus/include)
+  set(euslisp_INCLUDE_DIRS /home/ericles/Projetos/JSK/jsk-projects/jskeus/eus/include)
 else()
   find_package(euslisp REQUIRED)
   find_package(jskeus REQUIRED)
@@ -60,11 +60,11 @@ else()
       set(euslisp_PACKAGE_PATH ${euslisp_PREFIX}/share/euslisp)
     endif()
     message("-- Set euslisp_PACKAGE_PATH to ${euslisp_PACKAGE_PATH}")
-    set(euslisp_INCLUDE_DIRS ${euslisp_PACKAGE_PATH}/jskeus/eus/include)
+    set(euslisp_INCLUDE_DIRS /home/ericles/Projetos/JSK/jsk-projects/jskeus/eus/include)
   endif()
 endif()
-message("-- Set euslisp_INCLUDE_DIRS to ${euslisp_INCLUDE_DIRS}")
-include_directories(/usr/include /usr/X11R6/include ${euslisp_INCLUDE_DIRS} ${catkin_INCLUDE_DIRS})
+message("-- Set euslisp_INCLUDE_DIRS to /home/ericles/Projetos/JSK/jsk-projects/jskeus/eus/include")
+include_directories(/usr/include /usr/X11R6/include /home/ericles/Projetos/JSK/jsk-projects/jskeus/eus/include ${catkin_INCLUDE_DIRS})
 add_library(roseus roseus.cpp)
 add_library(eustf eustf.cpp)
 add_library(roseus_c_util roseus_c_util.c)

Even so on trying to install roseus, I got the following:

➜  kinetic sdo catkin build roseus
--------------------------------------------------------------
Profile:                     default
Extending:          [cached] /opt/ros/kinetic
Workspace:                   /home/ericles/ros/kinetic
--------------------------------------------------------------
Source Space:       [exists] /home/ericles/ros/kinetic/src
Log Space:          [exists] /home/ericles/ros/kinetic/logs
Build Space:        [exists] /home/ericles/ros/kinetic/build
Devel Space:        [exists] /home/ericles/ros/kinetic/devel
Install Space:      [unused] /home/ericles/ros/kinetic/install
DESTDIR:            [unused] None
--------------------------------------------------------------
Devel Space Layout:          linked
Install Space Layout:        None
--------------------------------------------------------------
Additional CMake Args:       None
Additional Make Args:        None
Additional catkin Make Args: None
Internal Make Job Server:    True
Cache Job Environments:      False
--------------------------------------------------------------
Whitelisted Packages:        None
Blacklisted Packages:        None
--------------------------------------------------------------
Workspace configuration appears valid.
--------------------------------------------------------------
[build] Found '9' packages in 0.0 seconds.                                                                                                            
[build] Package table is up to date.                                                                                                                  
Starting  >>> roseus                                                                                                                                  
______________________________________________________________________________________________________________________________________________________
Errors     << roseus:cmake /home/ericles/ros/kinetic/logs/roseus/build.cmake.016.log                                                                  
CMake Error at /home/ericles/ros/kinetic/src/jsk_roseus/roseus/CMakeLists.txt:54 (find_package):
  By not providing "Findeuslisp.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "euslisp", but
  CMake did not find one.

  Could not find a package configuration file provided by "euslisp" with any
  of the following names:

    euslispConfig.cmake
    euslisp-config.cmake

  Add the installation prefix of "euslisp" to CMAKE_PREFIX_PATH or set
  "euslisp_DIR" to a directory containing one of the above files.  If
  "euslisp" provides a separate development package or SDK, be sure it has
  been installed.


cd /home/ericles/ros/kinetic/build/roseus; catkin build --get-env roseus | catkin env -si  /usr/bin/cmake /home/ericles/ros/kinetic/src/jsk_roseus/rose
us --no-warn-unused-cli -DCATKIN_DEVEL_PREFIX=/home/ericles/ros/kinetic/devel/.private/roseus -DCMAKE_INSTALL_PREFIX=/home/ericles/ros/kinetic/install;
 cd -
......................................................................................................................................................
Failed     << roseus:cmake          [ Exited with code 1 ]                                                                                            
Failed    <<< roseus                [ 0.8 seconds ]                                                                                                   
[build] Summary: 0 of 1 packages succeeded.                                                                                                           
[build]   Ignored:   8 packages were skipped or are blacklisted.                                                                                      
[build]   Warnings:  None.                                                                                                                            
[build]   Abandoned: None.                                                                                                                            
[build]   Failed:    1 packages failed.                                                                                                               
[build] Runtime: 0.9 seconds total.

Do we have a Cmake file for euslisp? it seems to want to look at one of those. Or a different CMAKE_PREFIX_PATH, but I'm not sure what to do about it as yet
(btw, I did previously install euslisp on the jskeus folder aforementioned)..

Apart from that, new strange errors are popping up when running the tests with eus. The mtimer error has strangely gone for now, but then I got undefined function with-gensyms. I looked it up, and that macro really seems to be undefined (was it removed? I couldn't find its mention on recent commits though), so I defined it.. to get other stranger errors. I wonder whether there is some problem with the installation (I guess not, as it ran smoothly, with no apparent error messages), or whether the behavior with roseus is expected to be different on this matter (I guess not as well, but this is just guessing).

Maybe those errors are an expected result of recent changes.

Affonso-Gui · 2018-07-22T01:05:31Z

About the installation:

It seems that your build cannot locate the euslisp package (try to roscd euslisp). Since we are including it from source in the include_directories it should not be necessary, but it still remains listed as a dependency in the CMake, which is causing the errors.

You can try to:

apt-install and source euslisp (that is my case).
or
Fix the roseus CMake to do not depend on euslisp package anymore

About the tests:

The unittest makes uses of resources which are only available at roseus, such as mtimer, with-gensyms, and possibly others. At this point of time eus-test.l is only supported by roseus (and maybe irteusgl, I am not sure).

Maybe we should fix this too, since the test suite is designed for pure euslisp, without ros utilities.

EDIT: tests stopping after peek-char.1 is addressed on #29

ericlesaquiles · 2018-07-22T02:40:45Z

Just having apt-installed euslisp (and jskeus) is not enough (it was the first thing I tried, incidentally). Now, it goes too few arguments to function ‘cell*(...).. I'm trying to figure it out

About the tests, I think it is not a problem to trust in some of the roseus-only features, insofar as they're not ros-related features (it raises the question though.. if they're not ros related, why are they on roseus?). It seems enough for me to be aware we are making use of those features and to know which features they are (the second part could, perhaps, be better addressed closer to the end).

About the peek.. I'll try to adress it shortly (some of the others as well).

By the way, about the infix notation, did you consider #y (as in "ynfix")? it sound good to me

Affonso-Gui · 2018-07-22T05:57:25Z

Please post the complete result of catkin build roseus here so we can debug.

if they're not ros related, why are they on roseus?

Actually they seem to defined in the irt extension. Just tried, and appears that the tests also run well in irteusgl.

By the way, about the infix notation, did you consider #y (as in "ynfix")?

Seems good to me too. I am however also thinking in the possibility of leaving the infix macro on the lib/ (without loading it by default).

ericlesaquiles · 2018-07-22T15:28:34Z

It is in the issue 30

Actually they seem to defined in the irt extension. Just tried, and appears that the tests also run well in irteusgl.

Yes, (luckily for me) that seems to be the case

I am however also thinking in the possibility of leaving the infix macro on the lib/ (without loading it by default).

That's a solution, but if people are not using it much right now, I wonder if making them load it by hand wouldn't make them even less willing to use it. Not that it would make a big difference, though

ericlesaquiles · 2018-07-22T16:17:48Z

Are you not having segmentation fault as of now, @Affonso-Gui ?

k-okada · 2018-07-23T00:39:16Z

it compile euslisp/jskeus within catkin workspace, we need to add files manually.
For esulisp download CMakeLists.txt, package,xml, cmake/ and env-hook/ from https://github.com/tork-a/euslisp-release.
For jskeus, download CMakeLists.txt and package.xml from https://github.com/tork-a/jskeus-release

you can also check the script https://github.com/jsk-ros-pkg/jsk_roseus/blob/master/setup_upstream.sh

Affonso-Gui

Restore commented-out parts in search-aux.lsp using bit-vectors and eus-like subseq
The following auxiliary functions do not behave as expected. Please test your code before sending PRs.

equalp
substitute
substitute-if
substitute-if-not
nsubstitute
nsubstitute-if
nsubstitute-if-not
mismatch
peek-char

ericlesaquiles · 2018-07-22T19:26:56Z

auxiliary/eus-sequences.l

+
+
+;; Shadows peek-char to accept peek-type, and ignore it for now
+(defun peek-char (&optional (peek-type nil) (stream *standard-input*)


It shouldn't work.. I've accidentally pushed the wrong update, but will push the correct one as soon as I can (I'm without my computer right now)..

ericlesaquiles · 2018-07-24T01:19:45Z

I have no excuse for the errors on those functions, but they should hopefully be fine now.
Strangely, bit vectors still yield many errors

Fix auxiliary functions

k-okada requested a review from Affonso-Gui July 18, 2018 01:36

Affonso-Gui reviewed Jul 19, 2018

View reviewed changes

ericlesaquiles force-pushed the sequences branch from 15e13c9 to 405b8d6 Compare July 20, 2018 02:26

ericlesaquiles force-pushed the sequences branch from acf8f74 to cfe4e7c Compare July 21, 2018 17:05

ericlesaquiles added 2 commits July 21, 2018 23:43

Added sequence tests

52a2a9e

Return to percentage sign

d2991d3

ericlesaquiles force-pushed the sequences branch from cfe4e7c to d2991d3 Compare July 22, 2018 02:43

Shadows peek-char to accept peek-type

1a55dc0

Affonso-Gui mentioned this pull request Jul 23, 2018

Problem compiling roseus #30

Closed

Affonso-Gui requested changes Jul 23, 2018

View reviewed changes

ericlesaquiles commented Jul 24, 2018

View reviewed changes

ericlesaquiles added 2 commits July 23, 2018 22:08

Make a few functions work

decf007

Restored commented out bitvector-related

e2d3391

Affonso-Gui added 4 commits July 26, 2018 16:47

Fix mismatch

fc39354

Fix substitute

96956a8

Move character aux

379a45f

Avoid crashes on search-aux when testing from apt

eca69d2

Merge pull request #1 from Affonso-Gui/test-seqs

dc5f5f1

Fix auxiliary functions

Affonso-Gui approved these changes Aug 3, 2018

View reviewed changes

Merge branch 'gsoc2018' into sequences

b422050

Affonso-Gui merged commit efaedce into euslisp:gsoc2018 Aug 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added sequence tests #27

Added sequence tests #27

ericlesaquiles commented Jul 17, 2018

Affonso-Gui Jul 19, 2018

Affonso-Gui commented Jul 19, 2018

ericlesaquiles commented Jul 20, 2018

ericlesaquiles commented Jul 20, 2018 •

edited

Loading

Affonso-Gui commented Jul 21, 2018

Affonso-Gui commented Jul 21, 2018

ericlesaquiles commented Jul 21, 2018

Affonso-Gui commented Jul 22, 2018 •

edited

Loading

ericlesaquiles commented Jul 22, 2018

Affonso-Gui commented Jul 22, 2018 •

edited

Loading

ericlesaquiles commented Jul 22, 2018

ericlesaquiles commented Jul 22, 2018

k-okada commented Jul 23, 2018

Affonso-Gui left a comment •

edited

Loading

ericlesaquiles Jul 22, 2018

ericlesaquiles commented Jul 24, 2018



		;; Shadows peek-char to accept peek-type, and ignore it for now
		(defun peek-char (&optional (peek-type nil) (stream standard-input)

Added sequence tests #27

Added sequence tests #27

Conversation

ericlesaquiles commented Jul 17, 2018

Affonso-Gui Jul 19, 2018

Choose a reason for hiding this comment

Affonso-Gui commented Jul 19, 2018

ericlesaquiles commented Jul 20, 2018

ericlesaquiles commented Jul 20, 2018 • edited Loading

Affonso-Gui commented Jul 21, 2018

Affonso-Gui commented Jul 21, 2018

ericlesaquiles commented Jul 21, 2018

Affonso-Gui commented Jul 22, 2018 • edited Loading

ericlesaquiles commented Jul 22, 2018

Affonso-Gui commented Jul 22, 2018 • edited Loading

ericlesaquiles commented Jul 22, 2018

ericlesaquiles commented Jul 22, 2018

k-okada commented Jul 23, 2018

Affonso-Gui left a comment • edited Loading

Choose a reason for hiding this comment

ericlesaquiles Jul 22, 2018

Choose a reason for hiding this comment

ericlesaquiles commented Jul 24, 2018

ericlesaquiles commented Jul 20, 2018 •

edited

Loading

Affonso-Gui commented Jul 22, 2018 •

edited

Loading

Affonso-Gui commented Jul 22, 2018 •

edited

Loading

Affonso-Gui left a comment •

edited

Loading