removed css-modules dependency. #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to same as styles prop of Calendar component.
|
Thank you @mberneti! Looks very good. There are just a few things that I'll point out as "code review". |
mohebifar
suggested changes
Mar 7, 2017
src/components/DefaultStyles.js
Outdated
| @@ -0,0 +1,13 @@ | |||
| export const defaultStyles = { | |||
| calendarContainer: 'calendarContainer', | |||
There was a problem hiding this comment.
There's an extra indentation here.
src/components/DatePicker.js
Outdated
| @@ -20,13 +21,13 @@ export default class DatePicker extends Component { | |||
| inputFormat: PropTypes.string, | |||
| removable: PropTypes.bool, | |||
| timePickerComponent: PropTypes.func, | |||
| calendarStyles: PropTypes.object, | |||
| styles: PropTypes.object, | |||
There was a problem hiding this comment.
This is a breaking change, though I personally prefer styles over calendarStyles too. This is what @ilxanlar had chosen. I'm wondering if it's gonna break the Evand's web app after update.
src/components/DatePicker.js
Outdated
| calendarContainerProps: PropTypes.object | ||
| }; | ||
|
|
||
| static defaultProps = { | ||
| inputFormat: 'jYYYY/jM/jD', | ||
| calendarStyles: require('../styles/basic.css'), | ||
| styles: { ...defaultStyles, ...require('../styles/basic.css') }, |
There was a problem hiding this comment.
That require('../styles/basic.css') seems to be redundant as it gets overridden by defaultStyles anyways. We can stick with defaultStyles.
mberneti
changed the title
|
@mohebifar I think i fixed those couple issues in this commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.