V3 paging loadstate #195
Open
V3 paging loadstate #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedzie
reviewed
Aug 9, 2020
|
|
||
| val items = itemBindingOf<Any>(BR.item, R.layout.item_immutable) | ||
|
|
||
| val loadStateItems = OnItemBindLoadState.Builder<Any>() | ||
| .item(BR.item, R.layout.item_immutable) | ||
| .headerLoadState(BR.load, R.layout.network_state_item) |
There was a problem hiding this comment.
Can we split this into its own OnItemBindClass? so we can separate the layouts for error/progress cases
There was a problem hiding this comment.
Ideally would look like this
.headerLoadState( OnItemBindClass<LoadState>().apply {
map<LoadState.Error>(BR.item, R.layout.network_state_item_error)
map<LoadState.Loading>(ItemBinding.VAR_NONE, R.layout.network_state_item_progress)
} )
But in this case our item is Load not LoadState.Error..
|
Any plans on merging this anytime soon? |
|
is there a chance this PR would be merged in the future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.