Ocpp: cache and re-use initial status #16859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
force-pushed
the
fix/ocpp-initial-status
branch
from
3977372 to
05e588f
Compare
andig
commented
Oct 25, 2024
|
|
||
| // apply cached status if available | ||
| instance.WithChargepointStatusByID(cp.id, func(status *core.StatusNotificationRequest) { | ||
| if _, err := cp.OnStatusNotification(status); err == nil { |
There was a problem hiding this comment.
@premultiply bin noch gespannt, was hier bei >1 Connector passiert. Denn aktuell speichern wir nur einen Status- das müssten dann aber mehrere sein? Das ist aber erstmal ein Luxusproblem...
There was a problem hiding this comment.
@andig / @premultiply:
OCPP ABL Box leider mit
cannot create charger 'wb_re_2': cannot create charger type 'template': cannot create charger type 'ocpp': timeout
evcc 0.131.2 (520d54b) - sowohl mit der nightly als auch der 0.131.2.
wb_re_2 ist der 2. Ladepunkt der Box.
Wenn ich ein Issue eröffnen soll, bitte kurz melden.
There was a problem hiding this comment.
Lass uns erstmal nach der Mennekes schauen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May fix #15677