Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preparation to enable us to change home assistant addon #18730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dm82m
Copy link
Contributor

@dm82m dm82m commented Feb 11, 2025

preparation to enable us to change home assistant addon, details: evcc-io/hassio-addon#75

@dm82m
Copy link
Contributor Author

dm82m commented Feb 11, 2025

@thecem @goebelmeier please have a look

@dm82m
Copy link
Contributor Author

dm82m commented Feb 11, 2025

details (in german) about this PR can be found here: https://excalidraw.com/#json=SPLD4_VnJj9cjHwf-USks,f-Q6O4P1QGj21uEkeaF3Mw

@dm82m dm82m force-pushed the haaddon75 branch 3 times, most recently from 3cdc918 to 964181d Compare February 12, 2025 13:59
@dm82m dm82m marked this pull request as ready for review February 12, 2025 14:05
@dm82m dm82m force-pushed the haaddon75 branch 5 times, most recently from ecc2202 to b5de6aa Compare February 13, 2025 20:34
Copy link
Contributor

@goebelmeier goebelmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • sieht theoretisch gut aus
  • @dm82m sagt er hat das hoch und runter durchgetestet
  • shellcheck findet das Ergebnis am Ende sauber

Ich würde sagen LGTM und mich trauen, dass das gemerged wird! /cc @andig

@andig
Copy link
Member

andig commented Feb 14, 2025

Waiting for @thecem

Copy link
Contributor

@thecem thecem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dm82m dm82m force-pushed the haaddon75 branch 6 times, most recently from 2c540c5 to 0d2a26b Compare February 15, 2025 07:41
@dm82m
Copy link
Contributor Author

dm82m commented Feb 15, 2025

@andig all reviews are done, would be good to have it integrated before release of 0.200.1. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Basic functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants