-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce whitelist filtering #22
Conversation
Enabled filters on snapshot reading
…cified in subscriptions
table name, columns names and dimension of varchar column
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsfera thank you for the next set of changes.
For the future, it'd be great if you could split the changes into a few Pull Requests, and discuss them before sending a big PR. Having such big scope of changes makes it hard to review and consider in terms of the general API. In this case, changes could be split e.g. into:
- adding publication filter,
- adding table descriptor,
- ensuring
ConfigureAwait
is applied correctly, - etc.
I'd appreciate if you also consult bigger changes upfront.
I'm taking this PR as it is, as changes are good, and I want to review soon the current API and reshape it a bit in the follow-up set of changes.
Agree. I’m still in POC mode, as I want to add features to the project to verify how far we can go with it. |
@lsfera about different mime types, that sounds fair, but I'll need to do more research on e.g. how others are doing it (e.g. Debezium). EventStoreDB stores mime/type and always stores bytes. Then you can select your serialiser based on that. Definitely what I'd like to have is not enforce deserialisation of messages. This would, e.g. enable just forwarding messages as they are to other messaging systems or even streaming them through, e.g. web sockets. For that probably there'll be need to split:
Maybe others, but that would enable different use cases and even other tools like Brighter, MassTransit to use Blümchen internally and also regular applications for business needs. I'll need to sleep on that. Definitely, if I have some draft, I'll tag you in the PR. I think that we should not be doing any validation or manipulation of the data we're getting from the users. Even from the legal audit perspective it's better for the user to be sure that what they store is what they get in the database.
Yup, this would definitely help people having the capability to just do Also, later on I'd like to add WebHooks built-in support. That could be useful for doing serverless running Blumchen service e.g. on Fargate, that'd just forward events through HTTP to SQS or other services. |
closes #13
closes #10
Different specs for Pub/Sub
Allow message table customization