DEVPROD-15240: Redirect to new waterfall from legacy waterfall #8782
Conversation
service/waterfall.go
Outdated
| newUILink := fmt.Sprintf("%s/commits/%s", uis.Settings.Ui.UIv2Url, project.Identifier) | ||
|
|
||
| u := gimlet.GetUser(r.Context()) | ||
| if u != nil { | ||
| usr, ok := u.(*user.DBUser) | ||
| if ok { | ||
| if usr.BetaFeatures.SpruceWaterfallEnabled { | ||
| newUILink = fmt.Sprintf("%s/project/%s/waterfall", uis.Settings.Ui.UIv2Url, project.Identifier) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we make the default the waterfall page and only redirect to the commits page if they're not opted in to the beta? Since the beta period will be ending ~this week I think that will facilitate moving everyone to the waterfall (and simplify this cleanup by making the if statement deletable).
Also might we need to check if the admin feature is enabled, so that turning off the beta will automatically work without making more changes?
There was a problem hiding this comment.
I can reverse the if-statements! I'm a bit confused about the admin feature condition; on the frontend we implemented it so that if the admin feature is disabled, it turns off the waterfall page. It seems like we might be doing the opposite here which could be confusing
Another option if you want is to increase friction and just always link people to the new Waterfall page, which might annoy them, but that's okay
There was a problem hiding this comment.
(to clarify I'm just not sure what to do with admin settings, but I can definitely access them here in uis.Settings.Ui.BetaFeatures.SpruceWaterfallEnabled!)
There was a problem hiding this comment.
Thanks, good point. Makes sense to me.
minnakt
changed the title
DEVPROD-15240
Description
Currently, if you visit
evergreen.mongodb.comwith the setting to redirect to Spruce enabled, it automatically redirects to the old Project Health page. We should redirect to the new Waterfallor Project Health page based on a user's preferencesto introduce friction and encourage users to use the new page.Also updates the value of
"Open Page in New UI"links in the same way.Testing