-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVPROD-10179: Add task name and status filtering #8800
Open
sophstad
wants to merge
8
commits into
evergreen-ci:main
Choose a base branch
from
sophstad:DEVPROD-10179
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DEVPROD-10179
… DEVPROD-10179
hadjri
reviewed
Mar 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM but have one performance related question
versionLookupKey := "version" | ||
|
||
// Get version documents | ||
pipeline = append(pipeline, bson.M{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we verify the performance of this pipeline against e.g. server or mms?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-10179, DEVPROD-10180
Description
Add the ability to filter waterfall queries by task name or status. This query is run when a user applies a filter that results in
n < limit
versions being shown as active on the page.Previous implementations of this (e.g. for the project health page) had iterated through versions attempting to find one whose tasks matched the criteria. Here, we instead find recent tasks from
limit
unique versions that match the filters, and then look up the corresponding versions. Based on pipeline testing, performance seems acceptable since we only look at tasks within the 300 most recent versions. It's possible an index will further improve performance.Testing