Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-10179: Add task name and status filtering #8800

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sophstad
Copy link
Contributor

@sophstad sophstad commented Mar 6, 2025

DEVPROD-10179, DEVPROD-10180

Description

Add the ability to filter waterfall queries by task name or status. This query is run when a user applies a filter that results in n < limit versions being shown as active on the page.

Previous implementations of this (e.g. for the project health page) had iterated through versions attempting to find one whose tasks matched the criteria. Here, we instead find recent tasks from limit unique versions that match the filters, and then look up the corresponding versions. Based on pipeline testing, performance seems acceptable since we only look at tasks within the 300 most recent versions. It's possible an index will further improve performance.

Testing

  • Add pipeline unit tests
  • Add GraphQL unit tests
  • Clean up GraphQL testing data which had gotten a bit disorganized. This required modifying some existing tests to satisfy the new task/version data

@sophstad sophstad requested review from a team March 7, 2025 16:19
@sophstad sophstad marked this pull request as ready for review March 7, 2025 16:19
Copy link
Contributor

@hadjri hadjri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but have one performance related question

versionLookupKey := "version"

// Get version documents
pipeline = append(pipeline, bson.M{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we verify the performance of this pipeline against e.g. server or mms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants