Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-14995: remove check for number of task directories that fail to clean up #8810

Conversation

Kimchelly
Copy link
Contributor

DEVPROD-14995

Description

After looking at some hosts in prod, it seems like the agent unfortunately fails to clean up task directories pretty often on static hosts. While failing to clean up the task directory a few times should warrant a quarantine, it's more work to manage the more frequent quarantines (and I believe fixing the underlying task directory cleanup issue isn't that easy).

To make quarantines less frequent, I reduced the data directory health check to just see how much disk space is remaining, which is the most important thing when deciding whether or not to run the next task.

Testing

Existing tests pass.

@Kimchelly Kimchelly requested a review from a team March 10, 2025 14:12
Copy link
Contributor

@ZackarySantana ZackarySantana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! What change did you do for

To make quarantines less frequent, I reduced the data directory health check to just see how much disk space is remaining, which is the most important thing when deciding whether or not to run the next task.
?

@Kimchelly
Copy link
Contributor Author

Kimchelly commented Mar 10, 2025

The disk space check was #8801. That one is still likely useful and I left it as-is.

@Kimchelly Kimchelly enabled auto-merge (squash) March 10, 2025 15:07
@Kimchelly Kimchelly merged commit f224527 into evergreen-ci:main Mar 10, 2025
9 checks passed
@Kimchelly Kimchelly deleted the DEVPROD-14995_less_sensitive_task_dir_check branch March 10, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants