Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useful parameters to vserver and checks #292

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

matchaxnb
Copy link

Hello @evrardjp, Jean-Philippe,

I have added 2 parameters to your module:

vserver.quorum: allows to define the quorum weight needed to operate properly. If this quorum is not met, the sorry_server will respond instead. This allows for split brain avoidance mechanisms with a witness tie-breaker for example.

*_check.delay_loop: this parameter defines the base frequency with which health checks are done. delay_before_retry is an override for this parameter only in the case of failures. By setting delay_loop to an integer, the healthcheck will be run every that-much seconds.

I hope you like it, find it up to your standards, and merge it.

Copy link
Owner

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall. I would prefer if you would amend your commit with the port though, and push again on this branch.

templates/keepalived-checks.j2 Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants