Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the _hpa.tpl so it produses a valid HorizontalPodAutoscaler #147

Merged
merged 12 commits into from
Jun 21, 2024
Merged

Conversation

knutia
Copy link
Contributor

@knutia knutia commented Jun 21, 2024

Description

Types of changes

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have made design choices.
  • My design choices are documented in an Architecture Decision Record in the designated ARD folder of this repo.

Issues this PR fixes

Fixes #

Copy link
Contributor

@bjorges bjorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@knutia knutia merged commit 104e22a into master Jun 21, 2024
1 check passed
@knutia knutia deleted the fix-hpa branch June 21, 2024 11:29
mipieta pushed a commit to mipieta/helm-charts that referenced this pull request Jul 2, 2024
…-ace#147)

* Fix the _hpa.tpl so it produses a valid HorizontalPodAutoscaler

* set autoscaling enabled to false

* update versions

* lets try kubeconform for testing

* keep temp for a bit longer

* dont remake temp

* revert helm-test.sh changes and try run helm template

* try metrics.enabeld false

* reverce kubeconform try

* Add line back

* revers line

* Add line back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants