[WIP] EEI: charge for memory gas cost in useGas #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on decision in ewasm/design#75 |
axic
changed the title
axic
force-pushed
the
memorygas
branch
2 times, most recently
from
b9d8b07
to
c4ba6a1
Compare
jakelang
reviewed
Apr 28, 2018
| @@ -199,6 +199,9 @@ string toHex(evmc_uint256be const& value) { | |||
|
|
|||
| takeGas(gas); | |||
|
|
|||
| heraAssert((ffsl(gas) + ffsl(memory.size()) <= 64), "Memory gas calculation overflow."); //may need to find alternative to ffsl for cross-libc portability | |||
| takeGas(gas * memory.size() / GasSchedule::memoryPageSize * GasSchedule::memoryCostPerPage + 1); //round gas cost up | |||
There was a problem hiding this comment.
Unsure whether this should be rounded up or not.
There was a problem hiding this comment.
Not sure. What are the pros/cons for each?
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.