-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Multipart copy support #46
Comments
Quick question for @benwilson512 or who ever else might know... When doing a multipart copy, the Ruby library initiates an upload and passes the |
I found the same issue and ended up creating a patched version of ex_aws that supports it. Here's my patch for it: Just had a look at the latest @benwilson512 Am I missing something here? Or would you like me to submit this patch as a PR to add this support? |
I've been using this patch in production since Feb 2019. Looking at it again now because I'd quite like to move back to using the official version of ex_aws and this is the one thing that's stopping me. |
I'd love to see this library support a high level operation similar to
S3.upload
that would do a copy in parts transparently to the end user. The Ruby's SDKsAWS::S3::ObjectMultipartCopier
.We already have the
upload_part_copy
primitive, just need to do the coordination of all the parts and calculate start and end ranges and kick off a bunch of theupload_part_copy
commands similar to thedefimpl
in https://github.com/ex-aws/ex_aws_s3/blob/v2.0.1/lib/ex_aws/s3/upload.ex.I'll try to start a PR, but I'll probably need polishing help. My plan.
Task.async_streams
to iterate through the ranges, callingupload_part_copy
for each one.The text was updated successfully, but these errors were encountered: